all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
576 stars 150 forks source link

fix: define `research` and `promotion` contribution types #428

Closed mstomar698 closed 2 years ago

mstomar698 commented 2 years ago

What: Adding new keywords to parse-comment.js

Checklist:

vercel[bot] commented 2 years ago

@201B153 is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (4f3a74c) compared to base (17b99a6). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #428 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 16 16 Lines 407 407 Branches 46 46 ========================================= Hits 407 407 ``` | [Impacted Files](https://codecov.io/gh/all-contributors/app/pull/428?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=all-contributors) | Coverage Δ | | |---|---|---| | [lib/parse-comment.js](https://codecov.io/gh/all-contributors/app/pull/428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=all-contributors#diff-bGliL3BhcnNlLWNvbW1lbnQuanM=) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=all-contributors). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=all-contributors)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mstomar698 commented 2 years ago

@201B153 Looks like something is missing. where do we add the emoji?

Do we have to add emojis too?? where I don't read it in the issue can u guide me here?

image

mstomar698 commented 2 years ago

@201B153 Thanks for this one. LGTM now. I just noticed now that the emoji keys are in the CLI codebase. 😕 I think will do some refactoring later on regarding this one.

Ok, Thanks

tenshiAMD commented 2 years ago

@all-contributors add @201B153 for code

allcontributors[bot] commented 2 years ago

@tenshiAMD

I've put up a pull request to add @201B153! :tada:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.16.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: