search

all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
576 stars 150 forks source link

already contributed before message #443

Open aborruso opened 2 years ago

aborruso commented 2 years ago

Describe the bug

Hi I tried to add a contributor, but I have had already contributed before message.

But he hasn't actually been added yet. He's in a never-approved PR.

To Reproduce

The not approved PR https://github.com/ondata/i-dati-che-vorrei/pull/30

The error message https://github.com/ondata/i-dati-che-vorrei/issues/28#issuecomment-1047155231

Expected behavior

To add him, because he is neither in README nor in .all-contributorsrc

How to add him?

ManuelRauber commented 2 years ago

Same question here, I've made the mistake to ask the bot in multiple prs to add a contribution for different people, so I can accept them after all at once, but that will lead to merge conflicts. So I closed all PRs from the bot and wanted to recreate them, but nope. "Has contributed before" without being in the .all-contributorsrc file

ManuelRauber commented 2 years ago

@tenshiAMD Also uninstall and reinstall the bot does not help.

ManuelRauber commented 2 years ago

Ok, now I've asked the bot to add another contribution for the same people and it did a super strange PR: https://github.com/BoundfoxStudios/community-project/pull/112/files

This PR uses old code to update, because in the current contributors-file there are already people in it: https://github.com/BoundfoxStudios/community-project/blob/5ba79dbbe45e3219f79efcb88ed900e367fcb3cc/.all-contributorsrc But as you can see, the bot tries to update from an empty contributors list. This does not make sense at all.

ManuelRauber commented 2 years ago

Ok, i found it out: It reopened its old PR and tried to update from there.

Solution is:

1) Close all bot-related PRs 2) Make sure no branch exists anymore (they all are named like all-contributors/add-{username}) - just delete them 3) now you can ping the bot again to add someone

tenshiAMD commented 2 years ago

@ManuelRauber Ok noted. Let's see if I can check this one this week but I cannot promise. PRs are welcome.

We need to reproduce some failing tests first. For now, here's a workaround for this one, make sure all PRs are deleted related to that specific contributor and try again.