all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
553 stars 144 forks source link

fix: support usernames with multiple dashes #463

Closed brandonroberts closed 3 months ago

brandonroberts commented 1 year ago

What:

Fixes a bug where a username with multiple dashes is not formatted correctly and the username is not found

Why:

https://github.com/analogjs/analog/pull/362#issuecomment-1529114039

image

How:

Replaces all occurrences of a dash in the username. Removes all occurrences of the replacement characters

Checklist:

vercel[bot] commented 1 year ago

@brandonroberts is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c733295) 100.00% compared to head (a06f6e0) 100.00%.

:exclamation: Current head a06f6e0 differs from pull request most recent head 3926497. Consider uploading reports for the commit 3926497 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #463 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 16 16 Lines 451 451 Branches 53 53 ========================================= Hits 451 451 ``` | [Impacted Files](https://app.codecov.io/gh/all-contributors/app/pull/463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=all-contributors) | Coverage Δ | | |---|---|---| | [lib/parse-comment.js](https://app.codecov.io/gh/all-contributors/app/pull/463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=all-contributors#diff-bGliL3BhcnNlLWNvbW1lbnQuanM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 6:54pm
gr2m commented 3 months ago

@all-contributors add @brandonroberts for code and test

allcontributors[bot] commented 3 months ago

@gr2m

I've put up a pull request to add @brandonroberts! :tada:

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.19.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: