search

all-contributors / app

🤖 A GitHub App to automate acknowledging contributors to your open source projects
https://allcontributors.org
MIT License
553 stars 144 forks source link

The all-contributors bot only partially recognizes the contribution types "infra" and "doc" #487

Open jpivarski opened 5 months ago

jpivarski commented 5 months ago

I used "infra" as the contribution name, following https://allcontributors.org/docs/en/emoji-key

https://github.com/scikit-hep/awkward/pull/1224#issuecomment-1898884415

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

but in the pull request, the correct title, "Infrastructure (Hosting, Build-Tools, etc)", is added to the README.

https://github.com/scikit-hep/awkward/blob/fd53a67514f59c402566d926a9a56f87d90217bd/README.md?plain=1#L216

jpivarski commented 5 months ago

Same thing for "doc":

https://github.com/scikit-hep/awkward/pull/358#issuecomment-1898910431

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

but in the pull request, the correct title, "Documentation", is added to the README.

https://github.com/scikit-hep/awkward/blob/6bb9bc8c304908ba73b4de5b00e40d80a6c47b7a/README.md?plain=1#L221C319-L221C334

jpivarski commented 5 months ago

Okay, this is weird: it said the same thing for "code". I probably use "code" more often than anything else. Maybe this message is always misleading, but the bot does the right thing.

https://github.com/scikit-hep/awkward/pull/583#issuecomment-1898916917