search

all-contributors / cli

Tool to help automate adding contributor acknowledgements according to the all-contributors specification ✨
https://allcontributors.org
Other
413 stars 144 forks source link

Remove trailing whitespace (flagged by popular linters) #340

Closed klieret closed 2 years ago

klieret commented 2 years ago

I am using the trailing-whitespace pre-commit hook. It's one of the default hooks and hence is very popular[^1].

However, the all-contributors is currently inserting trailing whitespace in the contributor table. This means that pre-commit will fail for every PR that all-contributors is opening.

While the hook can fix this automatically with an additional commit, this behavior is still not exactly desired.

You can see the whitespace here.

[^1]: A quick search with sourcegraph tells me there's more than 2k repositories use this hook.

KnorpelSenf commented 2 years ago

Same issue here, but with a different linter. It looks like it now wraps the entire table into another tag <tbody> for unknown reason. The whitespace stems from a <tfoot> tag which is empty, useless, and gets added after the body.

It would be great if these changes could be reverted—or did the old layout not work well?

My huge diff is here now: https://github.com/grammyjs/grammY/pull/286/files

all-contributors-release-bot commented 2 years ago

:tada: This issue has been resolved in version 6.23.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

tenshiAMD commented 2 years ago

@klieret @KnorpelSenf Thanks for reporting. This should be fixed now when using the latest version of CLI. However, if you are using the bot, it is having some issues in deployment right now. We are currently investigating the cause. We will update you. Thanks!

tenshiAMD commented 2 years ago

@klieret @KnorpelSenf bot is now up to date. Please check. Thanks!

klieret commented 2 years ago

Awesome! Thanks a lot! 😃

KnorpelSenf commented 2 years ago

I can confirm that it works flawlessly now, thank you so much! 🎉

tenshiAMD commented 2 years ago

@all-contributors please add @KnorpelSenf for bug.

allcontributors[bot] commented 2 years ago

@tenshiAMD

I've put up a pull request to add @KnorpelSenf! :tada:

tenshiAMD commented 2 years ago

@all-contributors please add @klieret for bug.

allcontributors[bot] commented 2 years ago

@tenshiAMD

I've put up a pull request to add @klieret! :tada:

tenshiAMD commented 2 years ago

@KnorpelSenf @klieret You're welcome. Please drop a follow me to show your appreciation. Thanks! 🎉