update tensorflow requirement

all-of-us / workbench-snippets

Code snippets for use in All of Us Workbench notebooks.

BSD 3-Clause "New" or "Revised" License

14 stars 6 forks source link

update tensorflow requirement #66

Closed Qi77Qi closed 3 years ago

Qi77Qi commented 3 years ago

In new terra-docker stack, we'll install tensorflow (including both CPU and GPU) by default. See https://github.com/DataBiosphere/terra-docker/pull/209

lmk if there's anything else I should update

Unfortunately we don't have automated testing configured for the code in this repository yet so we set up this checklist as an automatic reminder:

[ ] Ensure that the smoke tests pass using the current (or upcoming) CDR
[ ] Update documentation relevant to this pull request

Questions? See CONTRIBUTING.md or file an issue so that we can get it documented!

deflaux commented 3 years ago

Thanks @Qi77Qi for keeping this library in mind.

Is this change actually needed to fix a problem? I would think that if the base image has tensorflow_cpu 2.5.0, this a requirement of tensorflow_cpu>=2.0.0 would be met.

Qi77Qi commented 3 years ago

base image has tensorflow 2.5.0...not tensorflow_cpu

When I run pip3 install nbstripout "git+git://github.com/all-of-us/workbench-snippets.git#egg=terra_widgets&subdirectory=py" manually, I can see it's trying to download tensorflow_cpu 2.5.0

Collecting tensorflow_cpu>=2.0.0
  Downloading tensorflow_cpu-2.5.0-cp37-cp37m-manylinux2010_x86_64.whl (168.3 MB)
     |████████████████████████████████| 168.3 MB 39 kB/s