For a workspace making heavy use of HTML snapshots, the show all comments tab was taking more than 3 minutes to display its output for 72 snapshots. Now it takes less than two seconds! The biggest gain was made by switching from using gsutil for the repetitive task to using a Python GCS library, but the addition of multiprocess also helps with the speed up.
Unfortunately we don't have automated testing configured for the code in this
repository yet so we set up this checklist as an automatic reminder:
[X ] Ensure that the smoke tests pass using the current (or upcoming) CDR
[X ] Update documentation relevant to this pull request
Questions? See CONTRIBUTING.md
or file an issue so that we can get it documented!
Fixes https://github.com/all-of-us/workbench-snippets/issues/54
For a workspace making heavy use of HTML snapshots, the show all comments tab was taking more than 3 minutes to display its output for 72 snapshots. Now it takes less than two seconds! The biggest gain was made by switching from using
gsutil
for the repetitive task to using a Python GCS library, but the addition ofmultiprocess
also helps with the speed up.Unfortunately we don't have automated testing configured for the code in this repository yet so we set up this checklist as an automatic reminder:
Questions? See CONTRIBUTING.md or file an issue so that we can get it documented!