Please provide a short summary of the changes introduced by this pull request and reference the GitHub issue # (if applicable). Examples with potential change categories are listed below. Please change the item content as needed.
BUGFIX - Headings hierarchy incorrect for CTA. Also added section H2 for team page and work page (#99 )
IMPROVEMENT - Created "Specialty" Prismic type. Modified team member Prismic posts to bring in specialties using the Specialty content type. Output using a list markup rather than used <br> so can be better navigated by screen readers.
IMPROVEMENT - Add section H2 for contact form
REFACTORING - Clean up unused CSS for team page
REFACTORING - Used blank alt text for team member profile photos as the team name is below
Accessibility Checklist:
The following are general checks to ensure that new content/functionality added to the All Purpose website is accessible. The new content could be a component, content section, etc. Refer to the developer checklist in Notion for more comprehensive testing. If any of the below checks are not applicable to the work, add [N/A] next to the check item.
[N/A]- [ ] All text against background meets WCAG 2.1 Level AA colour contrast requirements: minimum 4.5:1 for small text (below 18pt regular or 14pt bold) and 3:1 for larger text
[N/A]- [ ] Colour is not the only method used to convey information in the design
[N/A]- [ ] Link and button text is discernable from the surrounding text
[N/A]- [ ] Informative images added to Prismic have the appropriate alt text
[N/A]- [ ] Captions have been created and uploaded to Vimeo multimedia
[N/A]- [ ] Embedded video iframe code added to Prismic has a title attribute and value describing the content
[N/A]- [ ] Multimedia has a text transcript created and added in Prismic
[N/A]- [ ] All controls, links be accessed by keyboard only
[N/A]- [ ] The tabbing order makes sense
[N/A]- [ ] Keyboard focus is not lost or trapped as you tab through the page
[N/A]- [ ] Link/button text can be read out of context
[x] Content is hidden so it does not exclude particular users
[N/A]- [ ] All id attribute values on a page are unique
[N/A]- [ ] Icon-only buttons/links have an associated text label
[N/A]- [ ] Custom components such as tab panels, collapsible panels have the appropriate markup pattern and expected keyboard functionality
[N/A]- [ ] New pages have a page title (i.e. <title>)
[x] Content section titles are marked up with the appropriate headings levels
[N/A]- [ ] All content resizes proportionally when the page is zoomed in/magnified
[x] There are no console errors from eslint-plugin-jsx-a11y
[x] Running browser accessibility checkers (e.g Axe, IBM Equal Access Accessibility Checker, Lighthouse) does not produce errors on pages where changes were made
Pre-deployment Checklist:
[x] A self-review of the code was performed
[x] Code has comments, particularly in hard-to-understand areas
[x] Development code (e.g. console.logs, commented out areas not required for production) have been removed
[x] There are no console errors when running gatsby develop
[x] The changes have been tested across different browsers and mobile devices
[x] Running gatsby build leads to successful build with no errors
Description of Changes
Please provide a short summary of the changes introduced by this pull request and reference the GitHub issue # (if applicable). Examples with potential change categories are listed below. Please change the item content as needed.
<br>
so can be better navigated by screen readers.Accessibility Checklist:
The following are general checks to ensure that new content/functionality added to the All Purpose website is accessible. The new content could be a component, content section, etc. Refer to the developer checklist in Notion for more comprehensive testing. If any of the below checks are not applicable to the work, add
[N/A]
next to the check item.[N/A]- [ ] All text against background meets WCAG 2.1 Level AA colour contrast requirements: minimum 4.5:1 for small text (below 18pt regular or 14pt bold) and 3:1 for larger text [N/A]- [ ] Colour is not the only method used to convey information in the design [N/A]- [ ] Link and button text is discernable from the surrounding text [N/A]- [ ] Informative images added to Prismic have the appropriate
alt
text [N/A]- [ ] Captions have been created and uploaded to Vimeo multimedia [N/A]- [ ] Embedded video iframe code added to Prismic has atitle
attribute and value describing the content [N/A]- [ ] Multimedia has a text transcript created and added in Prismic [N/A]- [ ] All controls, links be accessed by keyboard only [N/A]- [ ] The tabbing order makes sense [N/A]- [ ] Keyboard focus is not lost or trapped as you tab through the page [N/A]- [ ] Link/button text can be read out of contextid
attribute values on a page are unique [N/A]- [ ] Icon-only buttons/links have an associated text label [N/A]- [ ] Custom components such as tab panels, collapsible panels have the appropriate markup pattern and expected keyboard functionality [N/A]- [ ] New pages have a page title (i.e.<title>
)eslint-plugin-jsx-a11y
Pre-deployment Checklist:
console.log
s, commented out areas not required for production) have been removedgatsby develop
gatsby build
leads to successful build with no errors