all-purpose / ap-website-v3

MIT License
0 stars 0 forks source link

99 wrong heading levels #100

Closed darthvadur closed 3 years ago

darthvadur commented 3 years ago

Description of Changes

Please provide a short summary of the changes introduced by this pull request and reference the GitHub issue # (if applicable). Examples with potential change categories are listed below. Please change the item content as needed.

  1. BUGFIX - Headings hierarchy incorrect for CTA. Also added section H2 for team page and work page (#99 )
  2. IMPROVEMENT - Created "Specialty" Prismic type. Modified team member Prismic posts to bring in specialties using the Specialty content type. Output using a list markup rather than used <br> so can be better navigated by screen readers.
  3. IMPROVEMENT - Add section H2 for contact form
  4. REFACTORING - Clean up unused CSS for team page
  5. REFACTORING - Used blank alt text for team member profile photos as the team name is below

Accessibility Checklist:

The following are general checks to ensure that new content/functionality added to the All Purpose website is accessible. The new content could be a component, content section, etc. Refer to the developer checklist in Notion for more comprehensive testing. If any of the below checks are not applicable to the work, add [N/A] next to the check item.

[N/A]- [ ] All text against background meets WCAG 2.1 Level AA colour contrast requirements: minimum 4.5:1 for small text (below 18pt regular or 14pt bold) and 3:1 for larger text [N/A]- [ ] Colour is not the only method used to convey information in the design [N/A]- [ ] Link and button text is discernable from the surrounding text [N/A]- [ ] Informative images added to Prismic have the appropriate alt text [N/A]- [ ] Captions have been created and uploaded to Vimeo multimedia [N/A]- [ ] Embedded video iframe code added to Prismic has a title attribute and value describing the content [N/A]- [ ] Multimedia has a text transcript created and added in Prismic [N/A]- [ ] All controls, links be accessed by keyboard only [N/A]- [ ] The tabbing order makes sense [N/A]- [ ] Keyboard focus is not lost or trapped as you tab through the page [N/A]- [ ] Link/button text can be read out of context

Pre-deployment Checklist:

darthvadur commented 3 years ago

going to merge these changes into the maintenance branch 101-upgrade-project-dep