search

allan-simon / sentence-aligner-rust

rest service + frontend to align sentences , in rust
13 stars 1 forks source link

[bug]Post new sentence accepts unknown language #39

Closed allan-simon closed 6 years ago

allan-simon commented 6 years ago

currently you can post a sentence with a language not known by the system and it will accept the post

BUT it will insert NULL in the language field, implicitly swallowing 3-letters code unknown to the server. it should fail with noise instead.

allan-simon commented 6 years ago

https://stackoverflow.com/questions/35495928/have-sql-query-fail-if-subquery-returns-null this one could permit that without requiring to split it in two requests.

jean553 commented 6 years ago

Fixed by https://github.com/allan-simon/sentence-aligner-rust/commit/aa5abbb9e8ef366afe03f3b55f7af7e1ea4808cc.