Should we update MSRV policy

allan2 / dotenvy

A well-maintained fork of the dotenv crate

MIT License

664 stars 40 forks source link

Should we update MSRV policy #33

Closed sonro closed 1 year ago

sonro commented 1 year ago

With a few tweaks* we can support Rust version 1.42.0 (September 2020).

But should we?

Ensuring support for Rust released 2 years ago seems sensible for a library primarily used in dev environments.

*Changes:

println! macros in docs
println! in 1 example

The examples certainly need updating anyway.

allan2 commented 1 year ago

Sure! Let's kick out the format strings.

Dylan-DPC commented 1 year ago

While at it, I'd rather push MSRV more aggressively, maybe to 1.56.1 at least so we can specify the rust version in Cargo.toml and maybe look through the codebase and see if we can add any other features that were introduced

sonro commented 1 year ago

Yes, maybe 2 years is a bit too conservative. 1.56.1 is 1 year ago (n-8). After going down the rabbit hole(1) of other crate's policies, n-8 seems like a good compromise.