search

allan2 / dotenvy

A well-maintained fork of the dotenv crate
MIT License
664 stars 40 forks source link

remove unnecessary ok on dotenv result #38

Closed xiaoas closed 1 year ago

xiaoas commented 1 year ago

fixes https://github.com/allan2/dotenvy/issues/37

Hope I've done this correctly🥲

github-actions[bot] commented 1 year ago

Code Coverage

LeoniePhiline commented 1 year ago

@sonro Wouldn't it be best to make examples use proper error handling instead?

This will help beginners find into best practices asap.

sonro commented 1 year ago

@LeoniePhiline

Wouldn't it be best to make examples use proper error handling instead?

I completely agree. This PR along with previous issues regarding this topic has led to a discussion about an API change (#39). Once that has been resolved more documentation (including examples) will surely follow.