search

allan2 / dotenvy

A well-maintained fork of the Rust dotenv crate
MIT License
625 stars 39 forks source link

About MSRV and the `cli` feature #71

Closed CosmicHorrorDev closed 1 year ago

CosmicHorrorDev commented 1 year ago

I'd like to open a PR to update the clap version to v4, but clap normally maintains a very aggressive MSRV compared to this crate's current MSRV. Do you think it would be appropriate to use a higher MSRV for the cli feature to keep up to date with clap updates while maintaining a more tame MSRV when not using the cli feature?

Dylan-DPC commented 1 year ago

Thanks for opening the issue. I'd rather have a single MSRV for the entire repo instead having a feature have a different one because it becomes trickier to handle and can be a footgun.