search

allan2 / dotenvy

A well-maintained fork of the dotenv crate
MIT License
688 stars 43 forks source link

Update clap to newest version #77

Closed unknowntrojan closed 11 months ago

unknowntrojan commented 1 year ago

This PR updates clap to the newest version. I was using dotenvy in a project and I saw it duplicating my clap dependency due to using an old version.

This change doesn't break anything as far as I'm aware as we don't expose any of clap's internals ourselves.

Dylan-DPC commented 1 year ago

Thanks for the PR. However we will have to bump our MSRV from 1.57.1 to 1.64.0 to accept this change which is fine by me but we probably have to check some stuff first if that should be done right now or now [or in a new major release]

unknowntrojan commented 1 year ago

That's fair.

Uzaaft commented 11 months ago

With ce5bfde5d758df2cf26ecd765f26be7219d348b2 this one should be good to go

Dylan-DPC commented 11 months ago

oh yeah sorry forgot about this, thanks