allan2 / dotenvy

A well-maintained fork of the Rust dotenv crate
MIT License
625 stars 39 forks source link

Reworked doctests to be able to compile on Windows #79

Closed vallentin closed 1 week ago

vallentin commented 1 year ago

Changed the #![cfg(unix)] into multiple #[cfg(unix)], to allow the doctests to compile on Windows

aidenfarley commented 3 months ago

Is anything preventing this from being merged?

vallentin commented 3 months ago

I'm just assuming @allan2 is busy or overlooked the PR :)

I already verified this locally, so in my opinion it is ready to be merged.

aidenfarley commented 3 months ago

Well if it is the latter, this gave the PR some attention. My guess is that he is busy, but I just wanted to make sure this didn't slip under the radar.

sonro commented 1 week ago

Nice catch!

Thanks for your pull request, and for your patience.