search

allan2 / dotenvy

A well-maintained fork of the dotenv crate
MIT License
688 stars 43 forks source link

Rename `dotenv` to `load` #94

Closed allan2 closed 1 month ago

allan2 commented 6 months ago

This PR renames the primary function that loads the dotenv file to load. dotenv is still around with a deprecation warning.

The renaming is discussed in #39.

This renaming follows the naming convention in Ruby and Go implementations, which use Dotenv.load and godotenv.Load respectively.

github-actions[bot] commented 6 months ago

Code Coverage

allan2 commented 6 months ago

I opened this but I would wait for further discussion in #39

aidenfarley commented 5 months ago

@allan2 Are you wishing to follow a more reserved or a more aggressive approach when it comes to getting these PRs merged and issues solved? I'm guessing, based on current behavior, that you're following a more reserved approach. It might be worth considering being more aggressive, and possibly considering the next release a breaking one. This would allow us to implement a huge amount of these features we're trying to get in and a give us a nice foundation to work on from here. Maybe a discussion could be opened about this, but ultimately it is your decision as the maintainer of the repository.

aidenfarley commented 5 months ago

I have been making a lot of comments in the recent days. If I'm doing too much, please let me know. I do not want to overstep my role as a user of this repo.

allan2 commented 1 month ago

@allan2 Are you wishing to follow a more reserved or a more aggressive approach when it comes to getting these PRs merged and issues solved?

It depends on the issue. The next release is a new API with lots of breaking changes.

I have been making a lot of comments in the recent days. If I'm doing too much, please let me know. I do not want to overstep my role as a user of this repo.

Not at all. PRs and discussions are welcome :)

Closing because this PR is no longer relevant

aidenfarley commented 1 month ago

@allan2 Do you have any specific issues or PRs you'd like completed first? I can't remember if I already commented this somewhere else, but I'm ready to help out where I can -- some direction would be nice.

allan2 commented 1 month ago

@aidenfarley I marked some issues with a good first issue label. Docs can always be improved as well.

If you do see something you would like to take on, just comment on the issue to let others know.