fix(substitution): no substition on cases where the variable does not exist

allan2 / dotenvy

A well-maintained fork of the Rust dotenv crate

MIT License

625 stars 39 forks source link

fix(substitution): no substition on cases where the variable does not exist #95

Closed sassman closed 3 months ago

sassman commented 4 months ago

adding a testcase to demonstrate the issue and the expectations

sassman commented 4 months ago

@allan2 I wonder if the illustrated behaviour is actually intented or if it's just misbehaving?

Today I accidentally stumbled upon this "bug" because one of our stored credentials did contain a substring starting with a $ that was not meant to trigger any substitution.

aidenfarley commented 3 months ago

Could you please provide the output you expected, and the output it gives? This will allow those of us that do not have the time, ability, etc. to help diagnose the issue, if any exists.

Also, I'm not sure what maintainers would like, but it would probably be better to open an issue with an MRE instead of adding a test case through a PR.

sassman commented 3 months ago

@aidenfarley You are so right, I was it a bit of a haste when reporting this. I created an issue #100