search

allanjude / zxfer

A continuation of development on zxfer, a popular script for managing ZFS snapshot replication
BSD 2-Clause "Simplified" License
124 stars 40 forks source link

backup fails if listsnapshots property is on #3

Closed callumgibson closed 9 years ago

callumgibson commented 10 years ago

If the listsnapshots property is enabled for a source pool, then zxfer will fail with the following error (using Ex1 from the manpage):

zxfer -dFkPv -g 376 -R storage backup01/pools

Checking grandfather status of all snapshots marked for deletion... Grandfather check passed. Setting properties/sources on destination filesystem "backup01/pools/storage". Creating destination filesystem "backup01/pools/storage@zxfer_55516_20140704145500 " with specified properties. cannot create 'backup01/pools/storage@zxfer_55516_20140704145500': snapshot delimi ter '@' in filesystem name Error when creating destination filesystem.

Disabling listsnapshots and rerunning works correctly.

allanjude commented 10 years ago

fixed in 75b96f96d6041c763ea130b6f367aa6fddae8ff1 by adding '-t filesystem,volume' to all 'zfs list' operations that are not '-t snapshot' so that only filesystems and volumes are listed, even if listsnapshots=on