search

allanjude / zxfer

A continuation of development on zxfer, a popular script for managing ZFS snapshot replication
BSD 2-Clause "Simplified" License
123 stars 40 forks source link

Added Linux ZFS support.... Detect FreeBSD 10 or later #41

Open nurse-curtis opened 6 years ago

nurse-curtis commented 6 years ago

Okay, so I primarily use FreeBSD, but I do have a Linux box and a couple VM's that use ZFS. So I added an OS check condition for Linux so that unsupported properties are dealt with. At least I was only able to determine that jailed,aclmode,shareiscsi,and volmode don't work when receiving from FreeBSD.

*** This is currently broken as it does not seem to check uname of the target when using -T hostname As well, I noticed that the latest version was restricting current versions of FreeBSD even though aclmode and aclinherit are now supported. So to ensure this was not just a Linux adaptation of an amazing tool, I added a really dumb check to differentiate between FreeBSD >= 10 and <10 (using the first number of the release version, so it isn't future-proofed after FreeBSD 19...)

This is my first attempt at something like this, so any feedback is appreciated!

nurse-curtis commented 6 years ago

Oh, and to further show my allegiance primarily being to FreeBSD, I factored in the significance of adding Linux support as only being worthy of a bump to version 1.1.7. A huge Canadian fan of BSD Now too!