search

allankp / pytest-testrail

pytest plugin for integration with TestRail, for creating testruns and updating results
MIT License
96 stars 124 forks source link

Relax requests dependency allowing upgrades #27

Closed neg3ntropy closed 7 years ago

neg3ntropy commented 7 years ago

Tested with requests 2.18.4.

Fixes https://github.com/dubner/pytest-testrail/issues/26

allankp commented 7 years ago

@soulrebel Sorry for the delay, if you can fix the conflicts. Happy for this to be merged.

davidemoro commented 7 years ago

setup.py should not pin an exact version of a library's dependencies, if needed >=, >, etc operators could be used. This breaks https://github.com/tierratelematics/cookiecutter-qa/pull/178 for example

neg3ntropy commented 7 years ago

I fixed the conflict, but since other versions were pinned I had to unpin them as well.

It is better to keep the setup.py with the complete range of supported versions or an approximation thereof, so that you allow your user to have their own versions of the libraries.

Then for local development instead you pin the version of all libraries in the txt file so that you test on a reproducible environment. This is what I did in this second commit.

allankp commented 7 years ago

@soulrebel Can you bump version please, to force a new release

allankp commented 7 years ago

Thanks for your contribution :)