search

allankp / pytest-testrail

pytest plugin for integration with TestRail, for creating testruns and updating results
MIT License
95 stars 125 forks source link

add test run autoсlosing #36

Closed Igur007 closed 6 years ago

Igur007 commented 6 years ago

@dubner is there a chance to have this merged?

allankp commented 6 years ago

@Igur007 Would prefer this as a flag, default I suspect is best set to True.

Also please add a test for this, thanks

Igur007 commented 6 years ago

@dubner review, please. Thanks in advance!

Igur007 commented 6 years ago

@apallier thanks for feedback, hope that fixed). New review is needed.

Igur007 commented 6 years ago

@dubner Does some problem block this request or is there any other unfixed issue?

apallier commented 6 years ago

@Igur007 Please, could you fix the bug with testrun_name in plugin.py line 295? (More info in my review above)

Igur007 commented 6 years ago

@apallier @dubner fixed the bug with testrun_name in plugin.py line 295

apallier commented 6 years ago

@Igur007 I'm so sorry but your correction doesn't work with options --tr-run-id or --tr-plan-id because in this case self.testrun_name is None. I propose to you a simpler solution that works in all cases:

print('[{}] Test run with ID={} was closed'.format(TESTRAIL_PREFIX, self.testrun_id))

Thank you.

Igur007 commented 6 years ago

@apallier got it. Thanks, forgot that If --tr-run-id or --tr-plan-id provided, option "--tr-testrun-name" will be ignored.

apallier commented 6 years ago

@allankp Don't you want to merge this PR?