allanoguis / Hacktoberfest-2024

T-Rex run clone built in React JS/Next JS. This project is dedicated to Hacktoberfest 2024 and all its contributors.
https://allanoguis.github.io/Hacktoberfest-2024/
MIT License
9 stars 13 forks source link

ShadCn Library for Components and Dark Theme Implementation #51

Open SunkaraboinaPraveenKumar opened 23 hours ago

SunkaraboinaPraveenKumar commented 23 hours ago

Is your feature request related to a problem? Please describe. It's Easy to use Shadcn UI Components in nextjs and using next-themes to switch between dark and light mode

Describe the solution you'd like Shadcn and next-themes

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

allanoguis commented 22 hours ago

Hi @SunkaraboinaPraveenKumar Thanks for checking the project out!

We have Shadcn installed in the project. Ref.: #27

Please give us further details regarding the solution.

SunkaraboinaPraveenKumar commented 22 hours ago

I can Integrate Clerk Authentication or if needed Authentication using any database and also create a leader board to store the best scores of each user as a leaderboard

Parth-G27 commented 20 hours ago

@SunkaraboinaPraveenKumar The UI which includes footer, game, hero all is being code with plain TailwindCSS. If we have to use shadCN, do we have to redo the UI for these components again ?

SunkaraboinaPraveenKumar commented 19 hours ago

No need ShadCn is component library only

Parth-G27 commented 19 hours ago

But the game & the gameEngine are in TailwindCSS, the theme switch of ShadCN wont work on them right ? @SunkaraboinaPraveenKumar . How do we solve that

SunkaraboinaPraveenKumar commented 19 hours ago

Yes it will not affect any styling we just need to install shadcn and use inbuilt components wherever required like buttons, alert boxes, toasts etc.. instead of hard coding everything. Please do assign me as a part of hacktoberfest 2024 i can do that

allanoguis commented 17 hours ago

Alright dude have a go at it. We'll check the pull request once you finish it. GLHF! Don't forget to update your fork @SunkaraboinaPraveenKumar we pushed a new update.

SunkaraboinaPraveenKumar commented 8 hours ago

Bro Why is my PR rejected by hacktoberfest saying your repo is registered under hacktober image

Parth-G27 commented 6 hours ago

your PR is there which you made 5 hrs ago, @allanoguis will review your PR. Good work @SunkaraboinaPraveenKumar

allanoguis commented 1 hour ago

Hi @SunkaraboinaPraveenKumar I'm still checking the PR. Here's what I found:

image

Can I have more information about this PR? I might also suggest a few fixes before having it approved. I appreciate the effort made in this development

Update: I saw that the Navigation and ClerkProvider was setup in the layout. Good take on this one. I would prefer doing this too personally.

image

I tried running it on my end but I kept getting errors. Can you guide us through this?

SunkaraboinaPraveenKumar commented 1 hour ago

Bro Please convert .env.example to .env.local which has clerk api keys then you can as git will not allow .env.local i adjusted it

SunkaraboinaPraveenKumar commented 1 hour ago

Once it is deployed no need of such keys but for local machine needed

allanoguis commented 6 minutes ago

@SunkaraboinaPraveenKumar still having the same error dude I wonder what's wrong. May I request for a revison on the PR request so that we can see the output?