search

allardbrain / clubhouse-client

Python client for Clubhouse
Apache License 2.0
5 stars 2 forks source link

Use the OpenAPI spec to generate the client #28

Open j-martin opened 4 years ago

j-martin commented 4 years ago

Clubhouse now publishes the spec for their API.

It might make sense to use it for code generation instead of manually maintaining the lower-level details and Type hints.

I am not sure which code generator should be used and if any of them can generate Type hints for example.

allardbrain commented 4 years ago

Thanks, @j-martin ! I'll look into this in more detail this week.

allardbrain commented 4 years ago

Hey @j-martin it's been awhile, but I've gotten back to working on this project. I spent some time learning about OpenAPI and client generators, and thanks for introducing these concepts.

I'm going to continue developing this package manually because I value the learning experience of creating an API wrapper from scratch for the first time. However, I'm open to re-working this in the future using an OpenAPI code generator.

j-martin commented 4 years ago

No worries. Looking at the dev branch you are doing admirable work with the heredocs and everything else. :) My gut reaction is always "can't a computer do that for me instead" though. ;)