Add Milestone endpoints - Githubissues

allardbrain / clubhouse-client

Python client for Clubhouse

Apache License 2.0

5 stars 2 forks source link

Add Milestone endpoints #5

Closed allardbrain closed 4 years ago

allardbrain commented 4 years ago

What changes does this PR introduce?

Moves the client logic out of __init__.py and into api.py
Adds internal helper methods for calling requests to the ClubhouseClient class in api.py
Adds a method for each Milestone endpoint offered by the Clubhouse API
Updates all dependency versions

Notes

The scope of this PR is larger than what would typically be acceptable. I set out to just add the Milestone endpoints, but made some structural changes as I discovered opportunities in the existing code. Now that I'm familiar with the code, I don't expect future PRs to be this large (or include out-of-scope changes).

Tests

I need to learn how to mock requests for unit tests. In an effort to maintain momentum on this project, I've decided to focus on adding as many endpoints as I can and creating a new issue for each group of endpoints that needs testing. (For example, I'll create an issue for adding all Milestone endpoint tests.)

allardbrain commented 4 years ago

Hey there, @j-martin 👋 Do you have any interest in reviewing this PR?