allboatsrise / expo-marketingcloudsdk

Expo module for Salesforce Marketing Cloud SDK
MIT License
12 stars 12 forks source link

Enable building with useFrameworks: "static" for iOS devices #11

Closed MarchewkaMatthew closed 1 year ago

MarchewkaMatthew commented 1 year ago

Hi @andrejpavlovic !

Thank you for maintaining this module. I have a question regarding building this plugin with useFrameworks: "static" set for iOS devices (added with the expo-build-properties). I need to add it in order to enable React Native Firebase in my project. I'm not really sure what that would require from the package to support building from the "framework" instead of the static library.

app.config.ts:

      [
        "expo-build-properties",
        {
          ios: {
            useFrameworks: "static",
          },
        },
      ],

Error message during run fastlane step in the eas build:

image

Thank you in advance for your help!

andrejpavlovic commented 1 year ago

Isn't that error related to this issue? https://github.com/allboatsrise/expo-marketingcloudsdk/issues/6

MarchewkaMatthew commented 1 year ago

Hi @andrejpavlovic, I'm not sure. in the eas build steps expo prebuild seems to work just fine. I also have expo-notifications added to my plugins list. I will try to add s.dependency 'EXNotifications' and let you know about the result.

MarchewkaMatthew commented 1 year ago

It indeed fixed the issue 👍 I've updated my PR to this repository: #9

andrejpavlovic commented 1 year ago

Published fix in 48.0.1