allcleardev / allclear-app

AllClear, an open source app for covid-19 status reporting, tracking and locating testing sites.
GNU Affero General Public License v3.0
6 stars 0 forks source link

AC-285: Only one testing location is expanded at a time #465

Closed bparrish17 closed 4 years ago

bparrish17 commented 4 years ago

Checklist for Pull Requests

🚨Please review the guidelines for contributing to this repository.

Description

Please describe anything in your pull request that isn't immediately understandable from the ticket description.

Thank you! 😎

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

crimsonsunset commented 4 years ago

holding until prod deploy

crimsonsunset commented 4 years ago

since the height of the container changes when you collapse an item, it allows the user to get into a situation where scrollTop at the time of calculation is not actually where you want to end up. I think you can get around this problem by delaying the scroll until after the other container is collapsed? or vice versa maybe

crimsonsunset commented 4 years ago

steps to recreate: 1) click map marker 1 on the map. first one expands. 2) click map marker 9 on the map. first one collapses, 9th one expands and scrolls but gets cut off here: image

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication