Allclear 501 - Githubissues

allcleardev / allclear-app

AllClear, an open source app for covid-19 status reporting, tracking and locating testing sites.

GNU Affero General Public License v3.0

6 stars 0 forks source link

Allclear 501 #483

Closed carriestreed closed 4 years ago

carriestreed commented 4 years ago

Checklist for Pull Requests

🚨Please review the guidelines for contributing to this repository.

[ ] Make sure your branch matches the naming conventions. (Something like: AC-152). Don't request your master!
[ ] Your branch should only contain changes relevant to the ticket it is named after.
[ ] Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev.
[ ] Check your code additions will fail neither code linting checks nor e2e test (this will be tested automatically when you open your PR).

Description

Please describe anything in your pull request that isn't immediately understandable from the ticket description.

Thank you! 😎

crimsonsunset commented 4 years ago

also worth noting that pins do not all float to the top of the list, they stay pinned in place

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

No Coverage information
0.0% Duplication

carriestreed commented 4 years ago

let me know if this is a blocker or not^

Heyyy so this isn't a blocker currently -- The UX needs to be hashed out a bit here first

carriestreed commented 4 years ago

also worth noting that pins do not all float to the top of the list, they stay pinned in place

same for this ^^ need to discuss UX first