AC-617 fix: distributed icons evenly focusing on icon instead of text - Githubissues

allcleardev / allclear-app

AllClear, an open source app for covid-19 status reporting, tracking and locating testing sites.

GNU Affero General Public License v3.0

6 stars 0 forks source link

AC-617 fix: distributed icons evenly focusing on icon instead of text #497

Closed MattMoran12 closed 4 years ago

MattMoran12 commented 4 years ago

Checklist for Pull Requests

🚨Please review the guidelines for contributing to this repository.

[ ] Make sure your branch matches the naming conventions. (Something like: AC-152). Don't request your master!
[ ] Your branch should only contain changes relevant to the ticket it is named after.
[ ] Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev.
[ ] Check your code additions will fail neither code linting checks nor e2e test (this will be tested automatically when you open your PR).

Description

The Icons are now spaced out evenly horizontally. The spacing is no longer based on the text under each icon so everything remains even.

Desktop view: desktopIconView

Iphone view: iphoneIconView

crimsonsunset commented 4 years ago

address issues here: (mostly just linting) https://app.codacy.com/gh/allcleardev/allclear-app/pullRequest?prid=5759852

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication