AC-481 feature: Experiences Workflow - Githubissues

allcleardev / allclear-app

AllClear, an open source app for covid-19 status reporting, tracking and locating testing sites.

GNU Affero General Public License v3.0

6 stars 0 forks source link

AC-481 feature: Experiences Workflow #501

Closed MattMoran12 closed 3 years ago

MattMoran12 commented 4 years ago

…, users can submit an experience of any test center

Checklist for Pull Requests

🚨Please review the guidelines for contributing to this repository.

[ ] Make sure your branch matches the naming conventions. (Something like: AC-152). Don't request your master!
[ ] Your branch should only contain changes relevant to the ticket it is named after.
[ ] Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev.
[ ] Check your code additions will fail neither code linting checks nor e2e test (this will be tested automatically when you open your PR).

Description

PR is still actively being worked on!

Done

added posative SVG's
created Positive and Negative workflow
user can submit a review to any test center
user will be blocked if multiple reviews are submitted on same day
created a generic border progress component (why many files were edited!)

crimsonsunset commented 4 years ago

fix codacity issues (mostly lint related) you can find them by running yarn lint

sonarqube duplicate issues should be mostly resolved by my comments above

MattMoran12 commented 4 years ago

To-Do

user experience updates if they submit multiple reviews to the same test center
minor UI work
put individual state objects into one large state object

MattMoran12 commented 3 years ago

To-Do

fix any new requests from reviewers

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

No Coverage information
1.4% Duplication

crimsonsunset commented 3 years ago

should probably block the entire modal if they have submitted instead of letting them go thru the flow again