Closed mmoyle closed 8 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hey @mmoyle Thanks for catching and fixing this one. Can you accept the CLA so I can merge this? Thank you!
Also the more go idiomatic approach would be to return an error if the response is nil.
Hi @bitte-ein-bit , thanks for the quick reply.
I did agree to the CLA. And force pushed two times. Not sure why it's pending.
For my issue the error is returned on line 129.
This is consistent with the documentation for net/http "If the returned error is nil, the Response will contain a non-nil Body which the user is expected to close." https://pkg.go.dev/net/http#Client.Do
Totals | |
---|---|
Change from base Build 8054055802: | 0.2% |
Covered Lines: | 417 |
Relevant Lines: | 1452 |
@mmoyle I've checked the CLA backend and can confirm the signature.
Fix for
⠋panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x157bc74]
when an http proxy is set. Or for whatever reason a response is not returned by the http client.
Update README.