allebb / pirrot

A radio repeater controller (supporting both simplex and duplex operation modes) for the RaspberryPi.
https://pirrot.hallinet.com
54 stars 12 forks source link

Automatic resolution of 'sox' and 'play' binaries. #8

Closed allebb closed 7 years ago

allebb commented 7 years ago

System to detect the location of the 'play' and 'sox' command.

At present, these are being set in the AudioBaseCommand class but should probably use set using the 'which sox' and 'which play' commands to aid automatic resolution.

On MacOSX based systems (where the binaries are copied to say /usr/local/sox) this path should be added to the system's PATH to ensure that these are identified correctly.

allebb commented 7 years ago

Using Ballen\Executioner this can resolve these and return them accordingly.

allebb commented 7 years ago

This code has been implemented into the AudioBaseController and uses Ballen\Executioner class to handle the request, this is working great now. I've also updated the MacOSX documentation to explain how to symlink the directories to ensure that they are in the system path.