search

allegro / bigcache

Efficient cache for gigabytes of data written in Go.
http://allegro.tech/2016/03/writing-fast-cache-service-in-go.html
Apache License 2.0
7.54k stars 597 forks source link

changed to uint64 keys #377

Closed raeidish closed 1 year ago

raeidish commented 1 year ago

closes #354

was trying to run benchmarks however when using uint32 keys i consistently ran into slice bounds out of range errors as seen below:

BenchmarkAppendToCache/1-shards-12 panic: runtime error: slice bounds out of range [98993:98992]

cristaloleg commented 1 year ago

@janisz ?

codecov-commenter commented 1 year ago

Codecov Report

Merging #377 (539c6e3) into main (74db1b9) will increase coverage by 0.50%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head 539c6e3 differs from pull request most recent head b5aab4e. Consider uploading reports for the commit b5aab4e to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   88.66%   89.16%   +0.50%     
==========================================
  Files          15       15              
  Lines         794      794              
==========================================
+ Hits          704      708       +4     
+ Misses         76       73       -3     
+ Partials       14       13       -1
Files Coverage Δ
shard.go 92.01% <100.00%> (+1.52%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 157556c...b5aab4e. Read the comment docs.