search

allegro / embedded-elasticsearch

Tool that ease up creation of integration tests with Elasticsearch
Apache License 2.0
269 stars 81 forks source link

Can no longer reuse an ES installation between runs #62

Open ewanmellor opened 6 years ago

ewanmellor commented 6 years ago

In embedded-elasticsearch 2.4.4, a change was made (see below) to delete the ES installation directory before installing. This means that it is no longer possible to re-use the ES installation between runs. I have been using embedded-elasticsearch for development so that I can easily have a cleanable ES install on my laptop without needing to manage a full ES cluster. That doesn't mean that I want it wiped every time though. It was very convenient to be able to keep the data in there during development, but wipe and reinstall when necessary.

This (I thought) was the point of the cleanInstallationDirectoryOnStop option, but that is basically useless now. It doesn't clean the directory when stopping, but it does it the next run regardless.

I think that this behavior should be made optional, either with the cleanInstallationDirectoryOnStop option, or a new cleanInstallationDirectoryOnStart option.

commit 9fd888bf0eefa9497321f6abb98da6b871dd60c1 (tag: embedded-elasticsearch-2.4.4)
Author: Grzegorz Kaczmarczyk <grzegorz.kaczmarczyk@allegro.pl>
Date:   Mon Feb 19 23:51:25 2018 +0100

    delete installation directory before installation
gaczm commented 6 years ago

Ok, this looks like a bug. I will investigate why that change happened, and if there is no reason for it revert that commit

rvillars commented 5 years ago

Is there an estimated time until this could be fixed? This is a real blocker to how we intend to use embedded-elasticsearch.

vdbxavier commented 5 years ago

10 min for me to decompress elastic6.6 (> 100Mo !) it's too long please