Open mbedna opened 5 years ago
essobedo
commented
5 years ago @mbedna I don't have this behavior. If ES is properly downloaded once, it won't download it the next time as you can see here: https://github.com/allegro/embedded-elasticsearch/blob/master/core/src/main/java/pl/allegro/tech/embeddedelasticsearch/ElasticDownloader.java#L48-L49
mbedna
commented
5 years ago @essobedo Elasticsearch is downloaded once. Elasticsearch plugins are downloaded each time test is run.
essobedo
commented
5 years ago @mbedna Ah ok, I miss read your question/problem as I don't use plugins, my bad. It is compatible with what I had in mind. Indeed, I wanted to propose a PR that will provide the ability to remove only specific folders like data instead of removing the entire directory and unzip it again at each execution to speed up the whole process, it would solve your problem too. Your problem and mine is due to this https://github.com/allegro/embedded-elasticsearch/blob/master/core/src/main/java/pl/allegro/tech/embeddedelasticsearch/ElasticSearchInstaller.java#L63
mbedna
commented
5 years ago @essobedo Could you create pull request with your changes?
essobedo
commented
5 years ago @mbedna as far as I remember there are some tests failing on specific versions of ES but I stopped working on it when I realized that this project sounds to be abandoned, no need to spend my spare time for nothing as the PR won't be reviewed and merged. If I see some activity again on this project, I will finish it
mbedna
commented
5 years ago @gaczm is this project abandoned or you guys are still working on it at allegro?
Will it be possible to avoid dowloading elasticsearch plugins if withCleanInstallationDirectoryOnStop is set to false? If not maybe it will be possible to add new option which could be used to turn off downloading plugins each time.