allegro / envoy-control

Envoy Control is a platform-agnostic, production-ready Control Plane for Service Mesh based on Envoy Proxy.
Apache License 2.0
100 stars 33 forks source link

Added dynamic forward proxy cluster #246

Closed lukidzi closed 3 years ago

lukidzi commented 3 years ago

There are a couple of small things. Also why do we need the pattern (can't we just allow all domains)? Envoy requirers it? Another thing: do we have a way to disable adding dynamic forward proxy as a spring property?

We don't want to use * because it would try to do requests to services which we don't support. We have a default_route which handle unknown services and return 404. We don't need to disable dynamic forward proxy, because you can only get it when specific property is passed from Envoy.