search

allegro / envoy-control

Envoy Control is a platform-agnostic, production-ready Control Plane for Service Mesh based on Envoy Proxy.
Apache License 2.0
100 stars 33 forks source link

Consul ACL support #247

Open scalp42 opened 3 years ago

scalp42 commented 3 years ago

Hi folks,

Are ACLs supported? Looking at the docs, it doesn't seem that there's a way to pass a Consul token.

Let me know if I missed it.

lukidzi commented 3 years ago

Hi. There is no option to configure Consul token at the moment. Does your Consul cluster requires ACL token for: https://www.consul.io/api-docs/health#list-nodes-for-service ?

slonka commented 3 years ago

It would require a change to add the token here: https://github.com/allegro/consul-recipes/blob/f42b2367f04fdd7646877889a61e4549aa50adcd/src/main/java/pl/allegro/tech/discovery/consul/recipes/watch/ConsulWatcher.java#L37 and then use it here: https://github.com/allegro/envoy-control/blob/43d51f58861c0b7ece057c807a6f8c1002346e4b/envoy-control-runner/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/infrastructure/consul/ConsulWatcherConfig.kt#L52 and pass it somewhere in the configuration. The change should not be complicated if you want to implement it.