search

allegro / grunt-maven-plugin

Grunt + Maven integration done right
Other
213 stars 32 forks source link

Node process not killed #2

Closed marceloverdijk closed 11 years ago

marceloverdijk commented 11 years ago

Using the grunt-maven-plugin I'm starting the Grunt watch task. This spawns a new Node process.

When running the mvn grunt:grunt the maven task keeps watching nicely. However when I close (Ctrl-C) the maven task, the Node process keeps running.

When I run the grunt task with the normal grunt executable then I don't see this issue. After terminating the grunt task, the Node process is also killed nicely.

adamdubiel commented 11 years ago

Can you give any details about OS You are running? Or if watch performs any specific tasks? I can't replicate issue.

marceloverdijk commented 11 years ago

I'm running Windows8 using grunt connect and watch.

adamdubiel commented 11 years ago

That gonna be bit tough to debug, as i have no access to Windows8 machine nor license and i tested it on Windows 7 and everything works fine. I suppose this is not bug of grunt-maven-plugin itself, rather effect of Maven and maven-exec-plugin cooperation.. I'm off for a holiday for a week now, so i wont be able to make any research until next week.

marceloverdijk commented 11 years ago

No worries. I'm running the grunt watch command now directly using grunt, and only use the maven plugin to package production builds.

I will try to create a minimal setup which reproduces this issue, so it might be easier to debug.

adamdubiel commented 11 years ago

Hi, did You manage to pin down root of the problem? I still haven't met anyone using Win8.

zzzLobster commented 11 years ago

I have the same problem. This is a bug of exec-maven-plugin. http://jira.codehaus.org/browse/MEXEC-24

adamdubiel commented 11 years ago

And what's worse a very old one.. i don't think i can fix it nor create workaround in grunt-maven-plugin (except for advising to run grunt watch directly from target-grunt on Windows).

zzzLobster commented 11 years ago

There is one question: is it really necessary? For me it is not really problem: when i start grunt watch (through grunt-maven-plugin) from IDE all works fine (because it's not start Windows command shell)

adamdubiel commented 11 years ago

Thats even better :) I'm not a Windows user (only running grunt-maven on vm before releasing) and don't know much about its specifics.