search

allegro / hermes

Fast and reliable message broker built on top of Kafka.
http://hermes.allegro.tech
Other
818 stars 218 forks source link

Compile with `-parameters` flag and upgrade GitHub Actions #1828

Open deejay1 opened 8 months ago

deejay1 commented 8 months ago

Compile hermes with -parameters flag, because newer Spring drops parameter resolution through bytecode scanning, see https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x#parameter-name-retention

szczygiel-m commented 7 months ago

Hey, looks like changing this flag causes test fouls due to spring and jackson org.springframework.core.codec.DecodingException: JSON decoding error: Cannot construct instance of pl.allegro.tech.hermes.api.EndpointAddressResolverMetadata, problem: Cannot invoke "java.util.Map.entrySet()" because "map" is null Could You please take a look at this? https://github.com/allegro/hermes/actions/runs/8187892486?pr=1828

deejay1 commented 7 months ago

Hey, looks like changing this flag causes test fouls due to spring and jackson org.springframework.core.codec.DecodingException: JSON decoding error: Cannot construct instance of pl.allegro.tech.hermes.api.EndpointAddressResolverMetadata, problem: Cannot invoke "java.util.Map.entrySet()" because "map" is null Could You please take a look at this? https://github.com/allegro/hermes/actions/runs/8187892486?pr=1828

I'll take a look at it tomorrow if I manage to