Move all build logic and dependencies installs to Makefile

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.

Apache License 2.0

191 stars 33 forks source link

Move all build logic and dependencies installs to Makefile #155

Closed adamdubiel closed 7 years ago

adamdubiel commented 7 years ago

travis.ci configuration uses make commands to be able to replicate CI builds on local machine

janisz commented 7 years ago

There is a problem with tarvis build. I restarted it but it failed again.

coveralls commented 7 years ago

Coverage increased (+10.1%) to 91.553% when pulling 713cfb8c53d38f9ad6ee7ec64ab71eaf86989d02 on travis_with_makefile into cc5e0dd42d6821aec7813586f8149e5b2894baad on master.

adamdubiel commented 7 years ago

...and now it passed. Either we get back to not running consul tests with Consul on CI right now, or we wait to see how reliable this tests are in longer run, what do you think?

janisz commented 7 years ago

I think we should merge it. I think build hang could be not related to changes you made.

adamdubiel commented 7 years ago

I know its not related to changes, but we might not be happy with builds failing randomly because of consul.

adamdubiel commented 7 years ago

@janisz fixed, now we have 2 targets: test (testing with coverage) and check (test + metalinter)

coveralls commented 7 years ago

Coverage increased (+10.1%) to 91.553% when pulling 26407f531a12f020eaa5b21c720d4b428b7e8eb6 on travis_with_makefile into cc5e0dd42d6821aec7813586f8149e5b2894baad on master.