search

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.
Apache License 2.0
191 stars 33 forks source link

Add support for consul SSL auth #160

Closed mhamann closed 7 years ago

mhamann commented 7 years ago

Even though the docs indicate that this client supports passing in SSL client and CA certs, there wasn't actually any code using those values.

Now there is. :-)

janisz commented 7 years ago

Hi @mhamann

Thanks four PR. It looks great although I'm not sure if we need to support custom certs. This flag is legacy from https://github.com/CiscoCloud/mesos-consul/issues/107. We do not provide SslCert nor SslCaCert options for Marathon (only VerifySsl) and I think we should be consistent about configuration options and remove SslCert and SslCaCert from consul.Config. Do you really need this options? If not, would you like to prepare patch that will remove them?

Unfortunately we have some problems with our travis build:

curl: (35) Unknown SSL protocol error in connection to releases.hashicorp.com:443

janisz commented 7 years ago

@mhamann Closing due to lack of activity.