search

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.
Apache License 2.0
191 stars 33 forks source link

Replace `[]*Tasks` with `[]Tasks` #192

Closed janisz closed 7 years ago

janisz commented 7 years ago

Task is small object (112 bytes) mostly pointers (4 strings and 2 arrays). There is no reason for using []*Tasks in Marathon response.

Refs: https://github.com/allegro/marathon-consul/pull/190#discussion_r103429767

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 90.625% when pulling c7ea2f52fdf25c716963e47cd076e6da8348f7ae on find_tasks into 14fcb0426741f68924b2aa9257f8fc4315cff878 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 90.625% when pulling 288ce4ec76c0f4435f4de5b730f9ec86d04629db on find_tasks into 1cf3a1ce8445660f8b76f188af238b4119e064e9 on master.