Register all application by default

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.

Apache License 2.0

191 stars 33 forks source link

Register all application by default #199

Closed guilhem closed 7 years ago

guilhem commented 7 years ago

To migrate from mesos-consul, we would like being able to register all application by default (with a daemon flag). An application may be able to unregister with a label consul to false|off|0|...

guilhem commented 7 years ago

I try to dig into code, but apps.MarathonConsulLabel seems to be used many times and logic build around it....

janisz commented 7 years ago

The logic behind apps.MarathonConsulLabel is to determine if application should be registered and the value is used as a service name. We probably can add flag to register all services but then we need to generate application names from marathon application name.

janisz commented 7 years ago

Duplicates https://github.com/allegro/marathon-consul/issues/82