Substitute $HOST and $PORT* in healthcheck command

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.

Apache License 2.0

191 stars 33 forks source link

Substitute $HOST and $PORT* in healthcheck command #232

Closed guilhem closed 7 years ago

coveralls commented 7 years ago

Coverage increased (+0.04%) to 87.474% when pulling 128683903dbe1e1173353adcd49d2b45d225c548 on guilhem:substitute-command into 64b04b0bb77466c74dfddd347157de3a39f23c7b on allegro:master.

guilhem commented 7 years ago

I don't know in case of bridged network... I just sure that it doesn't work for them either in current situation ;)

Marathon is running healthcheck shell commands with same execution context than a task... it's really hard to reproduce it.

janisz commented 7 years ago

You are right. This feature is not working right now so adding it should not damage any Marathon-Consul installation.

coveralls commented 7 years ago

Coverage increased (+0.04%) to 87.474% when pulling 8bf7b2ccbc3b1e10a2dbc9bdf268a084d426dd00 on guilhem:substitute-command into 64b04b0bb77466c74dfddd347157de3a39f23c7b on allegro:master.

coveralls commented 7 years ago

Coverage increased (+0.04%) to 87.474% when pulling 8bf7b2ccbc3b1e10a2dbc9bdf268a084d426dd00 on guilhem:substitute-command into 64b04b0bb77466c74dfddd347157de3a39f23c7b on allegro:master.

janisz commented 7 years ago

@guilhem Thanks!