Do not manage events on non-consul apps

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.

Apache License 2.0

191 stars 33 forks source link

Do not manage events on non-consul apps #234

Closed guilhem closed 7 years ago

guilhem commented 7 years ago

This fix a lot of issues when dealing with apps not managed by marathon-consul

guilhem commented 7 years ago

@janisz I dig really into code and don't find why tests are failing...

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 87.105% when pulling 476cfeebee46b34688fc01803ba98fb12225c0f1 on guilhem:filterTask into 64b04b0bb77466c74dfddd347157de3a39f23c7b on allegro:master.

guilhem commented 7 years ago

I'm closing this PR because as seen in comments it's not the right way to do it.