search

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.
Apache License 2.0
191 stars 33 forks source link

Migrate glide to dep #268

Closed fortrieb closed 7 years ago

fortrieb commented 7 years ago

Fix #267

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-3.002%) to 87.063% when pulling d6478aad0f605832df9f01420736873b83a1bb95 on fortrieb:master into 33394b5d9a16f9a99384508e8fc3312f2195eb8b on allegro:master.

fortrieb commented 7 years ago

You are right it should not add new files to vendor/, but dep tries to update dependency to the newest compatible version of a package. That's because there are new files in PR. You can find detailed information about setup in dep Readme.

janisz commented 7 years ago

New files are only generated by dependency to project itself. I've checked commit hashes and this change does not change used versions.

I updated linter so once you rebase build should pass.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-3.002%) to 87.063% when pulling 539f15cc14687ae2a0b89983701d06a041d35006 on fortrieb:master into b6533a4e14d1a09571b4e368296ab98574b7654a on allegro:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.066% when pulling 0ffab97228a55d1c4a755998ad838fa494300c6f on fortrieb:master into b6533a4e14d1a09571b4e368296ab98574b7654a on allegro:master.

janisz commented 7 years ago

@fortrieb Thanks!

janisz commented 7 years ago

@fortrieb It looks like you deleted more lines than any other contributor :smile: https://github.com/allegro/marathon-consul/graphs/contributors?from=2015-04-12&to=2017-10-11&type=d