search

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.
Apache License 2.0
191 stars 33 forks source link

ACL token passing integration test #272

Closed chemicL closed 7 years ago

chemicL commented 7 years ago

The ACL token passing has been carried over from the forked project, but it had no tests. I added an integration test, which proves the functionality works as expected.

janisz commented 7 years ago 
--- FAIL: TestACLTokenPassing (2.06s)
    Error Trace:    consul_test.go:1106
    Error:      "[%!s(*service.Service=&{serviceA.0_serviceA_8080 serviceA [marathon test marathon-task:serviceA.0] 127.0.0.1 true})]" should have 0 item(s), but has 1
    Messages:   Reading services list without ACL token should yield empty response

https://travis-ci.org/allegro/marathon-consul/builds/289041586#L2073

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 90.267% when pulling a755249f53a6eb9ea26c6094b5eda4aba5adcbd0 on acl_token_test into 033c1a2ec9f6fdf4ea65a3890bffa44859c9ce14 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 90.231% when pulling 659a702fdea01883b3909e0b041b9eb9edf70920 on acl_token_test into 033c1a2ec9f6fdf4ea65a3890bffa44859c9ce14 on master.

janisz commented 7 years ago

@chemicL Thanks a lot