don't search in all DCs if configured

allegro / marathon-consul

Integrates Marathon apps with Consul service discovery.

Apache License 2.0

191 stars 33 forks source link

don't search in all DCs if configured #297

Closed ojagodzinski closed 4 years ago

ojagodzinski commented 4 years ago

If some datacenter is marked in Consul cluster as "failed" Marathon-Consul still asks for services and fails after getting 500 in response. This PR adds option to configure single datacenter to ask for.

coveralls commented 4 years ago

Coverage increased (+0.08%) to 90.999% when pulling 480515452aa4809a63c9735582a3df4bfc12956e on consuldatacenters into 3d0bb6dc1eabd685f8982f395cbf1cd191a2a92d on master.

pbetkier commented 4 years ago

I feel that this and this are the problems. The fact that we fail on first error instead of continuing with services that we were able to load. Querying only single DC feels more like a nice addition.