allegro / tradukisto

A Java i18n library created to convert numbers to their word representations.
Apache License 2.0
204 stars 92 forks source link

Add Swedish support for number to word conversion #139

Closed R055A closed 1 year ago

R055A commented 1 year ago

Fixes #120

codecov-commenter commented 1 year ago

Codecov Report

Merging #139 (3380c1c) into master (e9a94fd) will decrease coverage by 0.02%. The diff coverage is 99.03%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
- Coverage     99.19%   99.18%   -0.02%     
- Complexity      425      447      +22     
============================================
  Files            67       72       +5     
  Lines          1736     1837     +101     
  Branches         50       56       +6     
============================================
+ Hits           1722     1822     +100     
  Misses            7        7              
- Partials          7        8       +1     
Files Coverage Δ
...llegro/finance/tradukisto/LongValueConverters.java 100.00% <100.00%> (ø)
...pl/allegro/finance/tradukisto/MoneyConverters.java 100.00% <100.00%> (ø)
...pl/allegro/finance/tradukisto/ValueConverters.java 100.00% <100.00%> (ø)
...allegro/finance/tradukisto/internal/Container.java 100.00% <100.00%> (ø)
...guages/swedish/SwedishIntegerToWordsConverter.java 100.00% <100.00%> (ø)
...uages/swedish/SwedishThousandToWordsConverter.java 100.00% <100.00%> (ø)
...isto/internal/languages/swedish/SwedishValues.java 100.00% <100.00%> (ø)
...ukisto/internal/support/SwedishNumberChunking.java 100.00% <100.00%> (ø)
...languages/swedish/SwedishLongToWordsConverter.java 85.71% <85.71%> (ø)
R055A commented 1 year ago

Codecov Report

Merging #139 (3380c1c) into master (e9a94fd) will decrease coverage by 0.02%. The diff coverage is 99.03%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
- Coverage     99.19%   99.18%   -0.02%     
- Complexity      425      447      +22     
============================================
  Files            67       72       +5     
  Lines          1736     1837     +101     
  Branches         50       56       +6     
============================================
+ Hits           1722     1822     +100     
  Misses            7        7              
- Partials          7        8       +1     

Files Coverage Δ
...llegro/finance/tradukisto/LongValueConverters.java 100.00% <100.00%> (ø)
...pl/allegro/finance/tradukisto/MoneyConverters.java 100.00% <100.00%> (ø)
...pl/allegro/finance/tradukisto/ValueConverters.java 100.00% <100.00%> (ø)
...allegro/finance/tradukisto/internal/Container.java 100.00% <100.00%> (ø)
...guages/swedish/SwedishIntegerToWordsConverter.java 100.00% <100.00%> (ø)
...uages/swedish/SwedishThousandToWordsConverter.java 100.00% <100.00%> (ø)
...isto/internal/languages/swedish/SwedishValues.java 100.00% <100.00%> (ø)
...ukisto/internal/support/SwedishNumberChunking.java 100.00% <100.00%> (ø)
...languages/swedish/SwedishLongToWordsConverter.java 85.71% <85.71%> (ø)

Hi @jglaszka I have fixed the long value conversion to Swedish words and added more testing for this