allegro / typescript-strict-plugin

Typescript plugin that allows turning on strict mode in specific files or directories.
MIT License
335 stars 29 forks source link

ts-expect-error always causes lint error in ts-strict files #21

Open sudall opened 2 years ago

sudall commented 2 years ago

I'm setting up build-time linting for a project (ie. tsc && tsc-strict) and noticed that ts-expect-error will always fail linting if the expected error is due to strict typing because tsc will think that there's no expected error (and say that the ts-expect-error should be removed) while tsc-strict will see the error. Any ideas for how to fix this? Perhaps tsc-strict could do the linting for all files or maybe there's a way to have tsc skip strict files?

For now, the best solution I can think of is to just use ts-ignore instead.

kamkry commented 2 years ago

Hi, currently tsc alone doesn't have any option to filter or select files from the CLI. In tsc-strict we filter errors produced by strict files in our code. What we could do in the future would be creating a script tsc-no-strict, which would run tsc and filter out every strict file.