search

allegroai / clearml-agent

ClearML Agent - ML-Ops made easy. ML-Ops scheduler & orchestration solution
https://clear.ml/docs/
Apache License 2.0
244 stars 92 forks source link

Modified limits for urllib3 library #172

Open jday1 opened 1 year ago

jday1 commented 1 year ago

https://github.com/allegroai/clearml-agent/issues/171

jkhenning commented 1 year ago

Hi @jday1, what's the reason for this update? In general, we try not to enforce specific versions and specify the minimum required versions, in order to allow users more flexibility

jday1 commented 1 year ago

Hi Jake,

This PR widens the allowed versions of the urllib library in keeping with ClearML's approach.

In my use case, I have libraries which I cannot upgrade cleanly as they require urllib>=2. Hence, I have raised this PR.

Cheers, James

jkhenning commented 1 year ago

I'm wondering is there are any breaking changes or things that might cause issues if we use newer versions

jday1 commented 11 months ago

I would not expect breaking changes but you could create a release candidate which users (including myself) could test out?

jkhenning commented 11 months ago

See the migration guide: https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html At first glance, it seems that the minimum thing to do is make sure this new constraint is only applied to python 3.7 and up (and keep the old constraint for lower versions)