search

allegroai / clearml-agent

ClearML Agent - ML-Ops made easy. ML-Ops scheduler & orchestration solution
https://clear.ml/docs/
Apache License 2.0
244 stars 92 forks source link

Fix ssh to http conversion for azure devops repos #185

Open mads-oestergaard opened 10 months ago

mads-oestergaard commented 10 months ago

This PR fixes https://github.com/allegroai/clearml-agent/issues/184 and also adds a test for dev.azure domains.

mads-oestergaard commented 10 months ago

@jkhenning any thoughts on this?

jkhenning commented 9 months ago

Hi @mads-oestergaard, as I mentioned in my last comment, I'd like to change this to check on the actual Azure URL (as it's a fixed URL anyway, and relying on opportunistic parsing is something I'd like to keep in the code)

mads-oestergaard commented 9 months ago

Hi @jkhenning thanks for answering. I got caught up with other things, but will give this a look again sometime next week